Fix issue #2070. Don't fail context update when there is a - #2098
Open
LGLO wants to merge 1 commit into
Open
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 263d604ec6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
send_mn_transaction record of a transaction that wasn't included in Midnight Ledger. Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>
gilescope
reviewed
Sep 7, 2026
| Err(LedgerContextError::InvalidTransaction(reason)) => { | ||
| let hash = hex::encode(tx.transaction_hash().0.0); | ||
| log::warn!( | ||
| "Tolerating well_formed rejection {reason} of tx 0x{hash} while replaying block" |
Contributor
There was a problem hiding this comment.
How do you know you're replaying a block at this point?
Contributor
Author
There was a problem hiding this comment.
The only call-site of this private method has:
/// Safety: only use during cold-start replay where no concurrent `spend()`/`mark_spent()`
/// calls are active — `pending_until` and `spent_utxos` clearing depend on per-block
/// `process_ttls` which is deferred. This is naturally satisfied by the toolkit, which
/// always replays all blocks to reconstruct state before building any transactions.
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixed #2070 by not crashing replay when there is a
send_mn_transactionrecord of a transaction that wasn't included in Midnight Ledger because it was not well formed.🗹 TODO before merging
📌 Submission Checklist
git commit -s) for the DCO🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links